tableam: Use in CREATE TABLE AS and CREATE MATERIALIZED VIEW.

Andres Freund <andres@anarazel.de>

Commit: 919e48b943014b1d4ab5d83e48dbc9f8e87e7be4
Author: Andres Freund <andres@anarazel.de>
Date: 2019-03-25T01:58:37Z
Releases: 12.0
tableam: Use in CREATE TABLE AS and CREATE MATERIALIZED VIEW.

Previously those directly performed a heap_insert(). Use
table_insert() instead.  The input slot of those routines is not of
the target relation - we could fix that by copying if necessary, but
that'd not be beneficial for performance. As those codepaths don't
access any AM specific tuple fields (say xmin/xmax), there's no need
to use an AM specific slot.

Author: Andres Freund
Reviewed-By: Haribabu Kommi
Discussion: https://postgr.es/m/20180703070645.wchpu5muyto5n647@alap3.anarazel.de

Files

PathChange+/−
src/backend/commands/createas.c modified +12 −12
src/backend/commands/matview.c modified +11 −12

Discussion