Horton

Fix use of dangling pointer in heap_delete() when logging replica identity

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 90f1ba7ecf01f063c0e113c72afcf8c1a64ca285
Author: Michael Paquier <michael@paquier.xyz>
Date: 2019-02-01T01:35:58Z
Releases: 9.5.16 
Fix use of dangling pointer in heap_delete() when logging replica identity

When logging the replica identity of a deleted tuple, XLOG_HEAP_DELETE
records include references of the old tuple.  Its data is stored in an
intermediate variable used to register this information for the WAL
record, but this variable gets away from the stack when the record gets
actually inserted.

Spotted by clang's AddressSanitizer.

Author: Stas Kelvish
Discussion: https://postgr.es/m/085C8825-AD86-4E93-AF80-E26CDF03D1EA@postgrespro.ru
Backpatch-through: 9.4

Files

PathChange+/−
src/backend/access/heap/heapam.c modified +1 −2

Discussion