Improve castNode notation by introducing list-extraction-specific variants.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 8f0530f58061b185dc385df42e62d78a18d4ae3e
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-04-10T17:51:53Z
Releases: 10.0
Improve castNode notation by introducing list-extraction-specific variants.

This extends the castNode() notation introduced by commit 5bcab1114 to
provide, in one step, extraction of a list cell's pointer and coercion to
a concrete node type.  For example, "lfirst_node(Foo, lc)" is the same
as "castNode(Foo, lfirst(lc))".  Almost half of the uses of castNode
that have appeared so far include a list extraction call, so this is
pretty widely useful, and it saves a few more keystrokes compared to the
old way.

As with the previous patch, back-patch the addition of these macros to
pg_list.h, so that the notation will be available when back-patching.

Patch by me, after an idea of Andrew Gierth's.

Discussion: https://postgr.es/m/14197.1491841216@sss.pgh.pa.us

Files

PathChange+/−
contrib/pg_stat_statements/pg_stat_statements.c modified +2 −2
contrib/postgres_fdw/deparse.c modified +1 −1
contrib/postgres_fdw/postgres_fdw.c modified +3 −3
src/backend/catalog/objectaddress.c modified +8 −8
src/backend/catalog/pg_proc.c modified +1 −1
src/backend/commands/aggregatecmds.c modified +2 −2
src/backend/commands/async.c modified +4 −4
src/backend/commands/collationcmds.c modified +1 −1
src/backend/commands/copy.c modified +3 −3
src/backend/commands/createas.c modified +1 −1
src/backend/commands/dropcmds.c modified +4 −4
src/backend/commands/explain.c modified +3 −3
src/backend/commands/extension.c modified +2 −2
src/backend/commands/foreigncmds.c modified +1 −1
src/backend/commands/functioncmds.c modified +3 −2
src/backend/commands/matview.c modified +1 −1
src/backend/commands/opclasscmds.c modified +3 −3
src/backend/commands/portalcmds.c modified +1 −1
src/backend/commands/prepare.c modified +2 −2
src/backend/commands/tablecmds.c modified +2 −2
src/backend/commands/trigger.c modified +1 −1
src/backend/commands/user.c modified +1 −1
src/backend/commands/view.c modified +1 −1
src/backend/executor/execExpr.c modified +1 −1
src/backend/executor/execTuples.c modified +1 −1
src/backend/executor/execUtils.c modified +1 −1
src/backend/executor/functions.c modified +4 −4
src/backend/executor/nodeAgg.c modified +2 −2
src/backend/executor/nodeHashjoin.c modified +1 −1
src/backend/executor/nodeLockRows.c modified +1 −1
src/backend/executor/nodeModifyTable.c modified +1 −1
src/backend/executor/nodeSubplan.c modified +4 −4
src/backend/executor/spi.c modified +9 −9
src/backend/nodes/nodeFuncs.c modified +8 −8
src/backend/optimizer/path/costsize.c modified +6 −6
src/backend/optimizer/path/indxpath.c modified +2 −2
src/backend/optimizer/path/joinrels.c modified +1 −1
src/backend/optimizer/plan/analyzejoins.c modified +1 −1
src/backend/optimizer/plan/createplan.c modified +4 −4
src/backend/optimizer/plan/planner.c modified +1 −1
src/backend/optimizer/plan/setrefs.c modified +1 −1
src/backend/optimizer/plan/subselect.c modified +1 −1
src/backend/optimizer/prep/prepunion.c modified +1 −1
src/backend/optimizer/util/clauses.c modified +1 −1
src/backend/optimizer/util/orclauses.c modified +1 −1
src/backend/optimizer/util/restrictinfo.c modified +3 −3
src/backend/parser/analyze.c modified +3 −3
src/backend/parser/gram.y modified +1 −1
src/backend/parser/parse_collate.c modified +4 −4
src/backend/parser/parse_expr.c modified +2 −2
src/backend/parser/parse_node.c modified +1 −1
src/backend/parser/parse_relation.c modified +1 −1
src/backend/parser/parse_type.c modified +2 −2
src/backend/parser/parse_utilcmd.c modified +9 −9
src/backend/rewrite/rewriteDefine.c modified +4 −4
src/backend/rewrite/rewriteHandler.c modified +5 −5
src/backend/tcop/postgres.c modified +6 −6
src/backend/tcop/pquery.c modified +3 −3
src/backend/utils/adt/ruleutils.c modified +5 −5
src/backend/utils/adt/selfuncs.c modified +1 −1
src/backend/utils/cache/plancache.c modified +11 −11
src/backend/utils/misc/guc.c modified +1 −1
src/backend/utils/mmgr/portalmem.c modified +1 −1
src/include/nodes/pg_list.h modified +7 −0
src/pl/plpgsql/src/pl_exec.c modified +2 −2

Discussion