Horton

Apply quotes more consistently to GUC names in logs

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 8d9978a7176a2805a8188605de3c16ffc914dc8a
Author: Michael Paquier <michael@paquier.xyz>
Date: 2023-11-30T05:11:45Z
Releases: 17.0 
Apply quotes more consistently to GUC names in logs

Quotes are applied to GUCs in a very inconsistent way across the code
base, with a mix of double quotes or no quotes used.  This commit
removes double quotes around all the GUC names that are obviously
referred to as parameters with non-English words (use of underscore,
mixed case, etc).

This is the result of a discussion with Álvaro Herrera, Nathan Bossart,
Laurenz Albe, Peter Eisentraut, Tom Lane and Daniel Gustafsson.

Author: Peter Smith
Discussion: https://postgr.es/m/CAHut+Pv-kSN8SkxSdoHano_wPubqcg5789ejhCDZAcLFceBR-w@mail.gmail.com

Files

PathChange+/−
contrib/pg_prewarm/autoprewarm.c modified +1 −1
src/backend/access/heap/vacuumlazy.c modified +1 −1
src/backend/access/transam/commit_ts.c modified +2 −2
src/backend/access/transam/xlog.c modified +2 −2
src/backend/commands/vacuum.c modified +1 −1
src/backend/commands/variable.c modified +1 −1
src/backend/libpq/be-secure-openssl.c modified +3 −3
src/backend/postmaster/bgworker.c modified +1 −1
src/backend/postmaster/checkpointer.c modified +1 −1
src/backend/postmaster/pgarch.c modified +1 −1
src/backend/storage/buffer/localbuf.c modified +1 −1
src/backend/storage/file/fd.c modified +1 −1
src/backend/storage/lmgr/predicate.c modified +1 −1
src/backend/tcop/postgres.c modified +5 −5
src/backend/utils/adt/pg_locale.c modified +2 −2
src/backend/utils/fmgr/dfmgr.c modified +2 −2
src/backend/utils/misc/guc.c modified +1 −1
src/backend/utils/misc/guc_tables.c modified +2 −2
src/test/modules/commit_ts/expected/commit_timestamp_1.out modified +6 −6
src/test/regress/expected/collate.icu.utf8.out modified +2 −2
src/test/regress/expected/jsonb.out modified +2 −2
src/test/regress/expected/json.out modified +2 −2

Discussion