Horton

Use the correct PG_DETOAST_DATUM macro in BRIN

Tomas Vondra <tomas.vondra@postgresql.org>

View on postgr.es
Commit: 8cea358b128fea93c8360c9521dcf954775a38ca
Author: Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2024-04-14T16:24:38Z
Releases: 16.3 
Use the correct PG_DETOAST_DATUM macro in BRIN

Commit 6bcda4a721 replaced PG_DETOAST_DATUM with PG_DETOAST_DATUM_PACKED
in two BRIN output functions, for minmax-multi and bloom opclasses. But
this is incorrect - the code is accessing the data through structs that
already include a 4B header, so the detoast needs to match that. But the
PACKED macro may keep the 1B header, which means the struct fields will
point to incorrect data.

Backpatch-through: 16
Discussion: https://postgr.es/m/1df00a66-db5a-4e66-809a-99b386a06d86%40enterprisedb.com

Files

PathChange+/−
src/backend/access/brin/brin_bloom.c modified +1 −1
src/backend/access/brin/brin_minmax_multi.c modified +1 −1

Discussion