Fix some confusing uses of const
Peter Eisentraut <peter@eisentraut.org>
Author:
Peter Eisentraut <peter@eisentraut.org>
Date: 2025-10-30T10:20:04Z
Releases:
19 (unreleased)
Fix some confusing uses of const
There are a few places where we have
typedef struct FooData { ... } FooData;
typedef FooData *Foo;
and then function declarations with
bar(const Foo x)
which isn't incorrect but probably meant
bar(const FooData *x)
meaning that the thing x points to is immutable, not x itself.
This patch makes those changes where appropriate. In one
case (execGrouping.c), the thing being pointed to was not immutable,
so in that case remove the const altogether, to avoid further
confusion.
Co-authored-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/CAEoWx2m2E0xE8Kvbkv31ULh_E%2B5zph-WA_bEdv3UR9CLhw%2B3vg%40mail.gmail.com
Discussion: https://www.postgresql.org/message-id/CAEoWx2kTDz%3Db6T2xHX78vy_B_osDeCC5dcTCi9eG0vXHp5QpdQ%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| contrib/pg_surgery/heap_surgery.c | modified | +2 −2 |
| src/backend/access/gin/ginget.c | modified | +1 −1 |
| src/backend/access/gin/ginpostinglist.c | modified | +2 −2 |
| src/backend/executor/execGrouping.c | modified | +4 −4 |
| src/backend/nodes/tidbitmap.c | modified | +1 −1 |
| src/backend/utils/adt/tsvector_op.c | modified | +6 −6 |
| src/include/access/gin_private.h | modified | +2 −2 |
| src/include/nodes/tidbitmap.h | modified | +1 −1 |
| src/tools/pgindent/typedefs.list | modified | +1 −0 |
Discussion
- Remove meaningless const qualifier from ginCompressPostingList() 2 messages · 2025-10-29 → 2025-10-30
- Fix incorrect const qualification for tbm_add_tuples() and itemptr_to_uint64() 2 messages · 2025-10-29 → 2025-10-30