Horton

Prohibit max_slot_wal_keep_size to value other than -1 during upgrade.

Amit Kapila <akapila@postgresql.org>

View on postgr.es
Commit: 8bfb231b43d7f6058041483f2b823dd52eac7bf8
Author: Amit Kapila <akapila@postgresql.org>
Date: 2023-11-10T03:15:01Z
Releases: 17.0 
Prohibit max_slot_wal_keep_size to value other than -1 during upgrade.

We don't want existing slots in the old cluster to get invalidated during
the upgrade. During an upgrade, we set this variable to -1 via the command
line in an attempt to prevent such invalidations, but users have ways to
override it. This patch ensures the value is not overridden by the user.

Author: Kyotaro Horiguchi
Reviewed-by: Peter Smith, Alvaro Herrera
Discussion: http://postgr.es/m/20231027.115759.2206827438943188717.horikyota.ntt@gmail.com

Files

PathChange+/−
src/backend/access/transam/xlog.c modified +19 −0
src/backend/replication/slot.c modified +5 −11
src/backend/utils/misc/guc_tables.c modified +1 −1
src/include/utils/guc_hooks.h modified +2 −0

Discussion