Horton

Replace AclObjectKind with ObjectType

Peter Eisentraut <peter_e@gmx.net>

View on postgr.es
Commit: 8b9e9644dc6a9bd4b7a97950e6212f63880cf18b
Author: Peter Eisentraut <peter_e@gmx.net>
Date: 2018-01-19T19:01:15Z
Releases: 11.0 
Replace AclObjectKind with ObjectType

AclObjectKind was basically just another enumeration for object types,
and we already have a preferred one for that.  It's only used in
aclcheck_error.  By using ObjectType instead, we can also give some more
precise error messages, for example "index" instead of "relation".

Reviewed-by: Michael Paquier <michael.paquier@gmail.com>

Files

PathChange+/−
contrib/dblink/dblink.c modified +2 −2
contrib/file_fdw/output/file_fdw.source modified +1 −1
contrib/pg_prewarm/pg_prewarm.c modified +1 −1
contrib/pgrowlocks/pgrowlocks.c modified +1 −1
contrib/test_decoding/expected/permissions.out modified +2 −2
src/backend/access/brin/brin.c modified +2 −2
src/backend/access/gin/ginfast.c modified +1 −1
src/backend/catalog/aclchk.c modified +327 −178
src/backend/catalog/namespace.c modified +4 −4
src/backend/catalog/objectaddress.c modified +80 −45
src/backend/catalog/pg_aggregate.c modified +1 −1
src/backend/catalog/pg_operator.c modified +4 −4
src/backend/catalog/pg_proc.c modified +1 −1
src/backend/catalog/pg_type.c modified +1 −1
src/backend/commands/aggregatecmds.c modified +1 −1
src/backend/commands/alter.c modified +9 −9
src/backend/commands/collationcmds.c modified +2 −2
src/backend/commands/conversioncmds.c modified +2 −2
src/backend/commands/dbcommands.c modified +8 −8
src/backend/commands/event_trigger.c modified +2 −2
src/backend/commands/extension.c modified +4 −4
src/backend/commands/foreigncmds.c modified +8 −8
src/backend/commands/functioncmds.c modified +13 −13
src/backend/commands/indexcmds.c modified +5 −5
src/backend/commands/lockcmds.c modified +2 −2
src/backend/commands/opclasscmds.c modified +8 −8
src/backend/commands/operatorcmds.c modified +5 −5
src/backend/commands/policy.c modified +1 −1
src/backend/commands/proclang.c modified +2 −2
src/backend/commands/publicationcmds.c modified +5 −5
src/backend/commands/schemacmds.c modified +5 −5
src/backend/commands/statscmds.c modified +1 −1
src/backend/commands/subscriptioncmds.c modified +3 −3
src/backend/commands/tablecmds.c modified +18 −18
src/backend/commands/tablespace.c modified +5 −5
src/backend/commands/trigger.c modified +4 −4
src/backend/commands/tsearchcmds.c modified +4 −4
src/backend/commands/typecmds.c modified +14 −14
src/backend/commands/user.c modified +1 −1
src/backend/executor/execExpr.c modified +2 −2
src/backend/executor/execMain.c modified +1 −1
src/backend/executor/execSRF.c modified +1 −1
src/backend/executor/nodeAgg.c modified +5 −5
src/backend/executor/nodeWindowAgg.c modified +4 −4
src/backend/parser/parse_utilcmd.c modified +2 −2
src/backend/rewrite/rewriteDefine.c modified +3 −3
src/backend/tcop/fastpath.c modified +2 −2
src/backend/utils/adt/dbsize.c modified +2 −2
src/backend/utils/adt/tid.c modified +2 −2
src/backend/utils/fmgr/fmgr.c modified +2 −2
src/include/catalog/objectaddress.h modified +3 −1
src/include/utils/acl.h modified +2 −33
src/pl/tcl/pltcl.c modified +1 −1
src/test/modules/dummy_seclabel/expected/dummy_seclabel.out modified +2 −2
src/test/regress/expected/alter_table.out modified +17 −1
src/test/regress/expected/copy2.out modified +3 −3
src/test/regress/expected/create_procedure.out modified +1 −1
src/test/regress/expected/lock.out modified +1 −1
src/test/regress/expected/privileges.out modified +76 −76
src/test/regress/expected/publication.out modified +1 −1
src/test/regress/expected/rowsecurity.out modified +9 −9
src/test/regress/expected/select_into.out modified +3 −3
src/test/regress/expected/sequence.out modified +1 −1
src/test/regress/expected/updatable_views.out modified +15 −15
src/test/regress/sql/alter_table.sql modified +21 −0