Horton

Use appendStringInfoString and appendPQExpBufferStr where possible

David Rowley <drowley@postgresql.org>

View on postgr.es
Commit: 8abc13a88938ef473b8a486186f1b96630450728
Author: David Rowley <drowley@postgresql.org>
Date: 2019-07-04T01:01:13Z
Releases: 13.0 
Use appendStringInfoString and appendPQExpBufferStr where possible

This changes various places where appendPQExpBuffer was used in places
where it was possible to use appendPQExpBufferStr, and likewise for
appendStringInfo and appendStringInfoString.  This is really just a
stylistic improvement, but there are also small performance gains to be
had from doing this.

Discussion: http://postgr.es/m/CAKJS1f9P=M-3ULmPvr8iCno8yvfDViHibJjpriHU8+SXUgeZ=w@mail.gmail.com

Files

PathChange+/−
contrib/postgres_fdw/deparse.c modified +4 −4
contrib/sepgsql/database.c modified +3 −3
contrib/sepgsql/label.c modified +1 −1
contrib/sepgsql/selinux.c modified +1 −1
contrib/test_decoding/test_decoding.c modified +2 −2
src/backend/access/rmgrdesc/heapdesc.c modified +2 −2
src/backend/commands/explain.c modified +1 −1
src/backend/utils/adt/ruleutils.c modified +1 −1
src/bin/pg_basebackup/streamutil.c modified +4 −4
src/bin/pg_ctl/pg_ctl.c modified +2 −2
src/bin/pg_dump/dumputils.c modified +2 −2
src/bin/pg_dump/pg_backup_archiver.c modified +3 −3
src/bin/pg_dump/pg_backup_db.c modified +1 −1
src/bin/pg_dump/pg_dumpall.c modified +2 −2
src/bin/pg_dump/pg_dump.c modified +79 −79
src/bin/pg_upgrade/dump.c modified +1 −1
src/bin/psql/command.c modified +2 −2
src/bin/psql/describe.c modified +47 −47
src/bin/scripts/clusterdb.c modified +1 −1
src/bin/scripts/reindexdb.c modified +1 −1
src/bin/scripts/vacuumdb.c modified +22 −22
src/fe_utils/string_utils.c modified +2 −2
src/interfaces/libpq/fe-auth-scram.c modified +7 −7
src/interfaces/libpq/fe-connect.c modified +2 −2
src/interfaces/libpq/fe-protocol3.c modified +2 −2

Discussion