Refactor function parse_subscription_options.
Amit Kapila <akapila@postgresql.org>
Refactor function parse_subscription_options. Instead of using multiple parameters in parse_subscription_options function signature, use the struct SubOpts that encapsulate all the subscription options and their values. It will be useful for future work where we need to add other options in the subscription. Also, use bitmaps to pass the supported and retrieve the specified options much like the way it is done in the commit a3dc926009. Author: Bharath Rupireddy Reviewed-By: Peter Smith, Amit Kapila, Alvaro Herrera Discussion: https://postgr.es/m/CALj2ACXtoQczfNsDQWobypVvHbX2DtgEHn8DawS0eGFwuo72kw@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/subscriptioncmds.c | modified | +206 −233 |
| src/tools/pgindent/typedefs.list | modified | +1 −0 |
Discussion
- Refactor "mutually exclusive options" error reporting code in parse_subscription_options 60 messages · 2021-05-19 → 2021-07-08