Horton

Get rid of copy_partition_key

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 8a0596cb656e357c391cccf12854beb2e05f3901
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2017-12-21T17:21:39Z
Releases: 11.0 
Get rid of copy_partition_key

That function currently exists to avoid leaking memory in
CacheMemoryContext in case of trouble while the partition key is being
built, but there's a better way: allocate everything in a memcxt that
goes away if the current (sub)transaction fails, and once the partition
key is built and no further errors can occur, make the memcxt permanent
by making it a child of CacheMemoryContext.

Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/20171027172730.eh2domlkpn4ja62m@alvherre.pgsql

Files

PathChange+/−
src/backend/utils/cache/relcache.c modified +9 −62

Discussion