Fix actively-misleading comments about the contents of struct pg_tm.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 89dba59590fdd03799a47daf8019890d4324fbcf
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-09-06T15:43:44Z
Releases: 15.0
Fix actively-misleading comments about the contents of struct pg_tm.

pgtime.h documented the PG interpretation of tm_mon right alongside
the POSIX interpretation of tm_year, with no hint that neither
comment was correct throughout our code.

Perhaps someday we ought to switch to using two separate struct
definitions to provide a clearer indication of which semantics are
in use where.  But I fear the tedium-versus-safety-gain tradeoff
would not be very good.

Discussion: https://postgr.es/m/CAJ7c6TOMG8zSNEZtCn5SPe+cCk3Lfxb71ZaQwT2F4T7PJ_t=KA@mail.gmail.com

Files

PathChange+/−
src/include/pgtime.h modified +9 −2

Discussion