For PowerPC instruction "addi", use constraint "b".

Noah Misch <noah@leadboat.com>

Commit: 89b4d7744c80ecb3f6bdf8a07ca711a043718db3
Author: Noah Misch <noah@leadboat.com>
Date: 2019-10-19T03:20:28Z
Releases: 13.0
For PowerPC instruction "addi", use constraint "b".

Without "b", a variant of the tas() code miscompiles on macOS 10.4.
This may also fix a compilation failure involving macOS 10.1.  Today's
compilers have been allocating acceptable registers with or without this
change, but this future-proofs the code by precisely conveying the
acceptable registers.  Back-patch to 9.4 (all supported versions).

Reviewed by Tom Lane.

Discussion: https://postgr.es/m/20191009063900.GA4066266@rfd.leadboat.com

Files

PathChange+/−
src/include/storage/s_lock.h modified +6 −1

Discussion