Fix planner's row-mark code for inheritance from a foreign table.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 889592344c48d3965567f331b4ea89dfe6447bce
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-06-02T18:38:14Z
Releases: 14.0
Fix planner's row-mark code for inheritance from a foreign table.

Commit 428b260f8 broke planning of cases where row marks are needed
(SELECT FOR UPDATE, etc) and one of the query's tables is a foreign
table that has regular table(s) as inheritance children.  We got the
reverse case right, but apparently were thinking that foreign tables
couldn't be inheritance parents.  Not so; so we need to be able to
add a CTID junk column while adding a new child, not only a wholerow
junk column.

Back-patch to v12 where the faulty code came in.

Amit Langote

Discussion: https://postgr.es/m/CA+HiwqEmo3FV1LAQ4TVyS2h1WM=kMkZUmbNuZSCnfHvMcUcPeA@mail.gmail.com

Files

Discussion