Fix possible loss of sync between rectypeid and underlying PLpgSQL_type.
Tom Lane <tgl@sss.pgh.pa.us>
Fix possible loss of sync between rectypeid and underlying PLpgSQL_type. When revalidate_rectypeid() acts to update a stale record type OID in plpgsql's data structures, it fixes the active PLpgSQL_rec struct as well as the PLpgSQL_type struct it references. However, the latter is shared across function executions while the former is not. In a later function execution, the PLpgSQL_rec struct would be reinitialized by copy_plpgsql_datums and would then contain a stale type OID, typically leading to "could not open relation with OID NNNN" errors. revalidate_rectypeid() can easily fix this, fortunately, just by treating typ->typoid as authoritative. Per report and diagnosis from Ashutosh Sharma, though this is not his suggested fix. Back-patch to v11 where this code came in. Discussion: https://postgr.es/m/CAE9k0Pkd4dZwt9J5pS9xhJFWpUtqs05C9xk_GEwPzYdV=GxwWg@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/pl/plpgsql/src/expected/plpgsql_record.out | modified | +6 −0 |
| src/pl/plpgsql/src/pl_exec.c | modified | +10 −1 |
| src/pl/plpgsql/src/sql/plpgsql_record.sql | modified | +1 −0 |
Discussion
- Calling PLpgSQL function with composite type fails with an error: "ERROR: could not open relation with OID ..." 6 messages · 2019-12-26 → 2019-12-27