Code cleanup inspired by recent resname bug report (doesn't fix the bug
Tom Lane <tgl@sss.pgh.pa.us>
Code cleanup inspired by recent resname bug report (doesn't fix the bug yet, though). Avoid using nth() to fetch tlist entries; provide a common routine get_tle_by_resno() to search a tlist for a particular resno. This replaces a couple uses of nth() and a dozen hand-coded search loops. Also, replace a few uses of nth(length-1, list) with llast().
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/catalog/pg_proc.c | modified | +2 −2 |
| src/backend/commands/comment.c | modified | +5 −5 |
| src/backend/commands/explain.c | modified | +10 −19 |
| src/backend/executor/execJunk.c | modified | +4 −8 |
| src/backend/optimizer/path/allpaths.c | modified | +4 −10 |
| src/backend/optimizer/plan/createplan.c | modified | +5 −4 |
| src/backend/parser/parse_relation.c | modified | +32 −16 |
| src/backend/parser/parse_target.c | modified | +77 −81 |
| src/backend/rewrite/rewriteManip.c | modified | +6 −164 |
| src/backend/utils/adt/not_in.c | modified | +2 −2 |
| src/backend/utils/adt/tid.c | modified | +5 −4 |
| src/include/parser/parsetree.h | modified | +10 −2 |