Horton

Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 8689e38263af7755b8100203e325a5953ed1e602
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-09-06T14:41:05Z
Releases: 11.0 
Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.

The NAMEDTUPLESTORE patch piggybacked on the infrastructure for
TABLEFUNC/VALUES/CTE RTEs, none of which can ever have dropped columns,
so the possibility was ignored most places.  Fix that, including adding a
specification to parsenodes.h about what it's supposed to look like.

In passing, clean up assorted comments that hadn't been maintained
properly by said patch.

Per bug #14799 from Philippe Beaudoin.  Back-patch to v10.

Discussion: https://postgr.es/m/20170906120005.25630.84360@wrigleys.postgresql.org

Files

PathChange+/−
src/backend/optimizer/util/relnode.c modified +2 −2
src/backend/parser/parse_relation.c modified +66 −32
src/backend/parser/parse_target.c modified +2 −2
src/backend/utils/adt/ruleutils.c modified +2 −2
src/include/nodes/parsenodes.h modified +5 −0

Discussion