Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: 85adb5e91ec2f45a388bef7a92a3d988c7e45501
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2020-10-15T17:32:34Z
Releases: 14.0
Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls

Pavan Deolasee recently noted that a few of the
HeapTupleHeaderIndicatesMovedPartitions calls added by commit
5db6df0c0117 are useless, since they are done after comparing t_self
with t_ctid.  But because t_self can never be set to the magical values
that indicate that the tuple moved partition, this can never succeed: if
the first test fails (so we know t_self equals t_ctid), necessarily the
second test will also fail.

So these checks can be removed and no harm is done.

Discussion: https://postgr.es/m/20200929164411.GA15497@alvherre.pgsql

Files

Discussion