Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd8 et al.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 85a6ad3cdf320ceef5671381bd4caafe984d8e6b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2014-11-30T17:21:01Z
Releases: 9.0.19
Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd8 et al.

Coverity complained that the "else" added to fillPGconn() was unreachable,
which it was.  Remove the dead code.  In passing, rearrange the tests so as
not to bother trying to fetch values for options that can't be assigned.

Pre-9.3 did not have that issue, but it did have a "return" that should be
"goto oom_error" to ensure that a suitable error message gets filled in.

Files

PathChange+/−
src/interfaces/libpq/fe-connect.c modified +1 −2