Previous fix for temporary file management broke returning a set from
Heikki Linnakangas <heikki.linnakangas@iki.fi>
Previous fix for temporary file management broke returning a set from PL/pgSQL function within an exception handler. Make sure we use the right resource owner when we create the tuplestore to hold returned tuples. Simplify tuplestore API so that the caller doesn't need to be in the right memory context when calling tuplestore_put* functions. tuplestore.c automatically switches to the memory context used when the tuplestore was created. Tuplesort was already modified like this earlier. This patch also removes the now useless MemoryContextSwitch calls from callers. Report by Aleksei on pgsql-bugs on Dec 22 2009. Backpatch to 8.1, like the previous patch that broke this.
Files
| Path | Change | +/− |
|---|---|---|
| contrib/dblink/dblink.c | modified | +1 −4 |
| contrib/pg_stat_statements/pg_stat_statements.c | modified | +3 −8 |
| contrib/tablefunc/tablefunc.c | modified | +2 −27 |
| contrib/xml2/xpath.c | modified | +1 −5 |
| src/backend/commands/prepare.c | modified | +4 −8 |
| src/backend/executor/execQual.c | modified | +1 −6 |
| src/backend/executor/functions.c | modified | +1 −4 |
| src/backend/executor/nodeWindowAgg.c | modified | +2 −2 |
| src/backend/executor/tstoreReceiver.c | modified | +1 −4 |
| src/backend/utils/mmgr/portalmem.c | modified | +4 −8 |
| src/backend/utils/sort/tuplestore.c | modified | +27 −4 |
| src/pl/plperl/plperl.c | modified | +2 −8 |
| src/pl/plpgsql/src/pl_exec.c | modified | +24 −14 |
| src/pl/plpgsql/src/plpgsql.h | modified | +2 −1 |