Code review for domain-constraints patch. Use a new ConstraintTest node
Tom Lane <tgl@sss.pgh.pa.us>
Code review for domain-constraints patch. Use a new ConstraintTest node type for runtime constraint checks, instead of misusing the parse-time Constraint node for the purpose. Fix some damage introduced into type coercion logic; in particular ensure that a coerced expression tree will read out the correct result type when inspected (patch had broken some RelabelType cases). Enforce domain NOT NULL constraints against columns that are omitted from an INSERT.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execQual.c | modified | +45 −46 |
| src/backend/nodes/copyfuncs.c | modified | +21 −17 |
| src/backend/nodes/equalfuncs.c | modified | +18 −1 |
| src/backend/nodes/outfuncs.c | modified | +19 −3 |
| src/backend/nodes/readfuncs.c | modified | +35 −1 |
| src/backend/optimizer/prep/preptlist.c | modified | +7 −1 |
| src/backend/optimizer/util/clauses.c | modified | +16 −17 |
| src/backend/parser/parse_coerce.c | modified | +79 −52 |
| src/backend/parser/parse_expr.c | modified | +8 −6 |
| src/backend/parser/parse_type.c | modified | +18 −7 |
| src/backend/utils/adt/ruleutils.c | modified | +13 −1 |
| src/backend/utils/cache/lsyscache.c | modified | +17 −9 |
| src/include/nodes/nodes.h | modified | +2 −1 |
| src/include/nodes/parsenodes.h | modified | +25 −3 |
| src/include/parser/parse_coerce.h | modified | +3 −1 |
| src/include/parser/parse_type.h | modified | +2 −1 |
| src/include/utils/lsyscache.h | modified | +2 −2 |
| src/test/regress/expected/domain.out | modified | +3 −4 |
| src/test/regress/sql/domain.sql | modified | +1 −2 |