Horton

Ensure write failure reports no-disk-space

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 83762d0a928d5ac97b6124d4da70a53f1a98fc33
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2020-06-19T20:46:07Z
Releases: 9.6.19 
Ensure write failure reports no-disk-space

A few places calling fwrite and gzwrite were not setting errno to ENOSPC
when reporting errors, as is customary; this led to some failures being
reported as
"could not write file: Success"
which makes us look silly.  Make a few of these places in pg_dump and
pg_basebackup use our customary pattern.

Backpatch-to: 9.5
Author: Justin Pryzby <pryzby@telsasoft.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/20200611153753.GU14879@telsasoft.com

Files

PathChange+/−
src/bin/pg_basebackup/pg_basebackup.c modified +12 −0
src/bin/pg_dump/pg_backup_directory.c modified +18 −1

Discussion