Record dependencies of a cast on other casts that it requires.
Tom Lane <tgl@sss.pgh.pa.us>
Record dependencies of a cast on other casts that it requires. When creating a cast that uses a conversion function, we've historically allowed the input and result types to be binary-compatible with the function's input and result types, rather than necessarily being identical. This means that the new cast is logically dependent on the binary-compatible cast or casts that it references: if those are defined by pg_cast entries, and you try to restore the new cast without having defined them, it'll fail. Hence, we should make pg_depend entries to record these dependencies so that pg_dump knows that there is an ordering requirement. This is not the only place where we allow such shortcuts; aggregate functions for example are similarly lax, and in principle should gain similar dependencies. However, for now it seems sufficient to fix the cast-versus-cast case, as pg_dump's other ordering heuristics should keep it out of trouble for other object types. Per report from David Turoň; thanks also to Robert Haas for preliminary investigation. I considered back-patching, but seeing that this issue has existed for many years without previous reports, it's not clear it's worth the trouble. Moreover, back-patching wouldn't be enough to ensure that the new pg_depend entries exist in existing databases anyway. Discussion: https://postgr.es/m/OF0A160F3E.578B15D1-ONC12588DA.003E4857-C12588DA.0045A428@notes.linuxbox.cz
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/catalog/pg_cast.c | modified | +22 −3 |
| src/backend/commands/functioncmds.c | modified | +10 −4 |
| src/backend/commands/typecmds.c | modified | +3 −1 |
| src/backend/parser/parse_coerce.c | modified | +21 −0 |
| src/include/catalog/pg_cast.h | modified | +2 −0 |
| src/include/parser/parse_coerce.h | modified | +2 −0 |
| src/test/regress/expected/create_cast.out | modified | +29 −0 |
| src/test/regress/sql/create_cast.sql | modified | +21 −0 |
| src/tools/valgrind.supp | modified | +1 −1 |
Discussion
- PG upgrade 14->15 fails - database contains our own extension 6 messages · 2022-10-13 → 2022-10-14