pg_dump: Remove some unused return values.

Nathan Bossart <nathan@postgresql.org>

Commit: 8213df9effaf0767efa7faf9b75fa500d4f45985
Author: Nathan Bossart <nathan@postgresql.org>
Date: 2024-07-02T16:22:06Z
Releases: 18.0
pg_dump: Remove some unused return values.

getSchemaData() does not use the return values of many of its get*
helper functions because they store the data elsewhere.  For
example, commit 92316a4582 introduced a separate hash table for
dumpable objects that said helper functions populate.  This commit
changes these functions to return void and removes their "int *"
parameters that returned the number of objects found.

Reviewed-by: Neil Conway, Tom Lane, Daniel Gustafsson
Discussion: https://postgr.es/m/ZmCAtVaOrHpf31PJ%40nathan

Files

PathChange+/−
src/bin/pg_dump/common.c modified +23 −46
src/bin/pg_dump/pg_dump.c modified +67 −215
src/bin/pg_dump/pg_dump.h modified +23 −26

Discussion