Block ALTER TABLE .. DROP NOT NULL on columns in replica identity index
Michael Paquier <michael@paquier.xyz>
Block ALTER TABLE .. DROP NOT NULL on columns in replica identity index Replica identities that depend directly on an index rely on a set of properties, one of them being that all the columns defined in this index have to be marked as NOT NULL. There was a hole in the logic with ALTER TABLE DROP NOT NULL, where it was possible to remove the NOT NULL property of a column part of an index used as replica identity, so block it to avoid problems with logical decoding down the road. The same check was already done columns part of a primary key, so the fix is straight-forward. Author: Haiying Tang, Hou Zhijie Reviewed-by: Dilip Kumar, Michael Paquier Discussion: https://postgr.es/m/OS0PR01MB6113338C102BEE8B2FFC5BD9FB619@OS0PR01MB6113.jpnprd01.prod.outlook.com Backpatch-through: 10
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/tablecmds.c | modified | +22 −9 |
| src/test/regress/expected/replica_identity.out | modified | +4 −0 |
| src/test/regress/sql/replica_identity.sql | modified | +4 −0 |
Discussion
- [BUG]Missing REPLICA IDENTITY check when DROP NOT NULL 5 messages · 2021-11-24 → 2021-11-25