Revert indexed and enlargable binary heap implementation.
Masahiko Sawada <msawada@postgresql.org>
Revert indexed and enlargable binary heap implementation. This reverts commit b840508644 and bcb14f4abc. These commits were made for commit 5bec1d6bc5 (Improve eviction algorithm in ReorderBuffer using max-heap for many subtransactions). However, per discussion, commit efb8acc0d0 replaced binary heap + index with pairing heap, and made these commits unnecessary. Reported-by: Jeff Davis Discussion: https://postgr.es/m/12747c15811d94efcc5cda72d6b35c80d7bf3443.camel%40j-davis.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/nodeGatherMerge.c | modified | +0 −1 |
| src/backend/executor/nodeMergeAppend.c | modified | +1 −1 |
| src/backend/postmaster/pgarch.c | modified | +1 −2 |
| src/backend/replication/logical/reorderbuffer.c | modified | +0 −1 |
| src/backend/storage/buffer/bufmgr.c | modified | +0 −1 |
| src/bin/pg_dump/pg_backup_archiver.c | modified | +0 −1 |
| src/bin/pg_dump/pg_dump_sort.c | modified | +1 −1 |
| src/common/binaryheap.c | modified | +32 −213 |
| src/include/lib/binaryheap.h | modified | +3 −37 |
| src/tools/pgindent/typedefs.list | modified | +0 −1 |
Discussion
- Improve eviction algorithm in ReorderBuffer 93 messages · 2023-12-12 → 2024-04-11