Make init_spin_delay() C89 compliant and change stuck spinlock reporting.
Andres Freund <andres@anarazel.de>
Make init_spin_delay() C89 compliant and change stuck spinlock reporting. The current definition of init_spin_delay (introduced recently in 48354581a) wasn't C89 compliant. It's not legal to refer to refer to non-constant expressions, and the ptr argument was one. This, as reported by Tom, lead to a failure on buildfarm animal pademelon. The pointer, especially on system systems with ASLR, isn't super helpful anyway, though. So instead of making init_spin_delay into an inline function, make s_lock_stuck() report the function name in addition to file:line and change init_spin_delay() accordingly. While not a direct replacement, the function name is likely more useful anyway (line numbers are often hard to interpret in third party reports). This also fixes what file/line number is reported for waits via s_lock(). As PG_FUNCNAME_MACRO is now used outside of elog.h, move it to c.h. Reported-By: Tom Lane Discussion: 4369.1460435533@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/storage/buffer/bufmgr.c | modified | +2 −2 |
| src/backend/storage/lmgr/lwlock.c | modified | +1 −1 |
| src/backend/storage/lmgr/s_lock.c | modified | +10 −8 |
| src/include/c.h | modified | +11 −0 |
| src/include/storage/s_lock.h | modified | +5 −4 |
| src/include/utils/elog.h | modified | +0 −12 |