Improve ERROR/LOG messages added by commits ddd5f4f54a and 7a424ece48.
Amit Kapila <akapila@postgresql.org>
Improve ERROR/LOG messages added by commits ddd5f4f54a and 7a424ece48. Additionally, in slotsync.c, replace one StringInfoData variable usage with a constant string to avoid palloc/pfree. Also, replace the inclusion of "logical.h" with "slot.h" to prevent the exposure of unnecessary implementation details. Reported-by: Kyotaro Horiguchi, Masahiko Sawada Author: Shveta Malik based on suggestions by Robert Haas and Amit Kapila Reviewed-by: Kyotaro Horiguchi, Amit Kapila Discussion: https://postgr.es/m/20240214.162652.773291409747353211.horikyota.ntt@gmail.com Discussion: https://postgr.es/m/20240219.134015.1888940527023074780.horikyota.ntt@gmail.com Discussion: https://postgr.es/m/CAD21AoCYXhDYOQDAS-rhGasC2T+tYbV=8Y18o94sB=5AxcW+yA@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/replication/logical/slotsync.c | modified | +27 −38 |
| src/test/recovery/t/040_standby_failover_slots_sync.pl | modified | +1 −1 |
Discussion
- About a recently-added message 20 messages · 2024-02-14 → 2024-02-23
- Synchronizing slots from primary to standby 936 messages · 2021-10-31 → 2024-06-07
- A new message seems missing a punctuation 13 messages · 2024-02-19 → 2024-02-21