Horton

Remove useless casts to (void *)

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 7f798aca1d5df290aafad41180baea0ae311b4ee
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2024-11-28T07:27:20Z
Releases: 18.0 
Remove useless casts to (void *)

Many of them just seem to have been copied around for no real reason.
Their presence causes (small) risks of hiding actual type mismatches
or silently discarding qualifiers

Discussion: https://www.postgresql.org/message-id/flat/461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org

Files

PathChange+/−
contrib/amcheck/verify_nbtree.c modified +1 −1
contrib/bloom/blinsert.c modified +1 −1
contrib/bloom/blutils.c modified +1 −1
contrib/btree_gist/btree_bit.c modified +1 −1
contrib/btree_gist/btree_bool.c modified +2 −2
contrib/btree_gist/btree_bytea.c modified +1 −1
contrib/btree_gist/btree_cash.c modified +3 −3
contrib/btree_gist/btree_date.c modified +3 −3
contrib/btree_gist/btree_enum.c modified +2 −2
contrib/btree_gist/btree_float4.c modified +3 −3
contrib/btree_gist/btree_float8.c modified +3 −3
contrib/btree_gist/btree_inet.c modified +2 −2
contrib/btree_gist/btree_int2.c modified +3 −3
contrib/btree_gist/btree_int4.c modified +3 −3
contrib/btree_gist/btree_int8.c modified +3 −3
contrib/btree_gist/btree_interval.c modified +3 −3
contrib/btree_gist/btree_macaddr8.c modified +2 −2
contrib/btree_gist/btree_macaddr.c modified +2 −2
contrib/btree_gist/btree_numeric.c modified +1 −1
contrib/btree_gist/btree_oid.c modified +3 −3
contrib/btree_gist/btree_text.c modified +2 −2
contrib/btree_gist/btree_time.c modified +4 −4
contrib/btree_gist/btree_ts.c modified +5 −5
contrib/btree_gist/btree_uuid.c modified +2 −2
contrib/file_fdw/file_fdw.c modified +4 −4
contrib/hstore/hstore_op.c modified +1 −1
contrib/intarray/_int_bool.c modified +3 −3
contrib/ltree/_ltree_gist.c modified +1 −1
contrib/ltree/_ltree_op.c modified +9 −9
contrib/pgcrypto/openssl.c modified +1 −1
contrib/pg_trgm/trgm_gist.c modified +1 −1
contrib/postgres_fdw/postgres_fdw.c modified +5 −5
src/backend/access/brin/brin.c modified +2 −2
src/backend/access/brin/brin_minmax_multi.c modified +4 −4
src/backend/access/common/detoast.c modified +1 −1
src/backend/access/gin/ginbulk.c modified +1 −1
src/backend/access/gin/gininsert.c modified +2 −3
src/backend/access/gist/gistbuild.c modified +2 −2
src/backend/access/gist/gist.c modified +1 −1
src/backend/access/hash/hash.c modified +1 −1
src/backend/access/heap/vacuumlazy.c modified +1 −1
src/backend/access/nbtree/nbtree.c modified +5 −5
src/backend/access/nbtree/nbtsort.c modified +2 −2
src/backend/access/spgist/spginsert.c modified +1 −1
src/backend/access/spgist/spgutils.c modified +1 −1
src/backend/access/transam/twophase.c modified +2 −3
src/backend/access/transam/xlogrecovery.c modified +4 −4
src/backend/catalog/dependency.c modified +2 −2
src/backend/catalog/heap.c modified +1 −1
src/backend/catalog/index.c modified +1 −1
src/backend/catalog/objectaccess.c modified +8 −8
src/backend/catalog/pg_proc.c modified +1 −1
src/backend/catalog/pg_publication.c modified +1 −1
src/backend/commands/copyfrom.c modified +1 −1
src/backend/commands/foreigncmds.c modified +1 −1
src/backend/commands/indexcmds.c modified +1 −1
src/backend/commands/lockcmds.c modified +1 −1
src/backend/commands/policy.c modified +3 −3
src/backend/commands/publicationcmds.c modified +3 −3
src/backend/commands/tablecmds.c modified +5 −5
src/backend/commands/tablespace.c modified +1 −1
src/backend/commands/typecmds.c modified +1 −1
src/backend/commands/vacuum.c modified +1 −1
src/backend/commands/variable.c modified +3 −3
src/backend/executor/execExpr.c modified +1 −2
src/backend/executor/execExprInterp.c modified +17 −17
src/backend/executor/execIndexing.c modified +1 −1
src/backend/executor/functions.c modified +2 −2
src/backend/executor/nodeAgg.c modified +6 −7
src/backend/executor/nodeSort.c modified +1 −1
src/backend/executor/nodeWindowAgg.c modified +4 −4
src/backend/libpq/hba.c modified +1 −1
src/backend/nodes/nodeFuncs.c modified +2 −2
src/backend/nodes/params.c modified +1 −1
src/backend/nodes/read.c modified +1 −1
src/backend/optimizer/geqo/geqo_main.c modified +1 −1
src/backend/optimizer/path/costsize.c modified +1 −2
src/backend/optimizer/path/indxpath.c modified +1 −1
src/backend/optimizer/plan/createplan.c modified +1 −3
src/backend/optimizer/plan/setrefs.c modified +11 −19
src/backend/optimizer/plan/subselect.c modified +7 −14
src/backend/optimizer/prep/prepagg.c modified +1 −2
src/backend/optimizer/prep/prepjointree.c modified +10 −18
src/backend/optimizer/util/appendinfo.c modified +2 −3
src/backend/optimizer/util/clauses.c modified +13 −16
src/backend/optimizer/util/predtest.c modified +5 −5
src/backend/optimizer/util/tlist.c modified +2 −4
src/backend/optimizer/util/var.c modified +20 −25
src/backend/parser/analyze.c modified +1 −1
src/backend/parser/parse_agg.c modified +6 −6
src/backend/parser/parse_collate.c modified +8 −8
src/backend/parser/parse_cte.c modified +6 −6
src/backend/parser/parse_node.c modified +1 −1
src/backend/parser/parse_param.c modified +5 −5
src/backend/parser/scan.l modified +1 −1
src/backend/partitioning/partprune.c modified +1 −2
src/backend/port/sysv_shmem.c modified +3 −3
src/backend/replication/logical/logical.c modified +22 −22
src/backend/replication/logical/tablesync.c modified +1 −1
src/backend/replication/slot.c modified +1 −1
src/backend/replication/syncrep.c modified +1 −1
src/backend/rewrite/rewriteDefine.c modified +2 −2
src/backend/rewrite/rewriteHandler.c modified +4 −5
src/backend/rewrite/rewriteManip.c modified +34 −47
src/backend/storage/buffer/bufmgr.c modified +2 −2
src/backend/storage/buffer/buf_table.c modified +1 −1
src/backend/storage/ipc/shmem.c modified +2 −2
src/backend/tcop/postgres.c modified +3 −3
src/backend/tsearch/dict_thesaurus.c modified +1 −1
src/backend/tsearch/spell.c modified +1 −1
src/backend/tsearch/ts_locale.c modified +1 −1
src/backend/tsearch/ts_parse.c modified +6 −6
src/backend/tsearch/wparser.c modified +4 −4
src/backend/utils/adt/acl.c modified +1 −1
src/backend/utils/adt/arrayfuncs.c modified +7 −7
src/backend/utils/adt/array_userfuncs.c modified +4 −4
src/backend/utils/adt/datetime.c modified +1 −1
src/backend/utils/adt/datum.c modified +2 −2
src/backend/utils/adt/domains.c modified +3 −3
src/backend/utils/adt/enum.c modified +1 −1
src/backend/utils/adt/expandedrecord.c modified +4 −4
src/backend/utils/adt/jsonb.c modified +2 −2
src/backend/utils/adt/jsonfuncs.c modified +13 −13
src/backend/utils/adt/jsonpath_exec.c modified +1 −1
src/backend/utils/adt/jsonpath_scan.l modified +1 −1
src/backend/utils/adt/lockfuncs.c modified +1 −1
src/backend/utils/adt/multirangetypes.c modified +2 −2
src/backend/utils/adt/orderedsetaggs.c modified +1 −1
src/backend/utils/adt/partitionfuncs.c modified +2 −2
src/backend/utils/adt/rangetypes.c modified +2 −2
src/backend/utils/adt/regexp.c modified +2 −2
src/backend/utils/adt/tsgistidx.c modified +1 −1
src/backend/utils/adt/tsrank.c modified +3 −3
src/backend/utils/adt/tsvector_op.c modified +1 −1
src/backend/utils/adt/xml.c modified +7 −7
src/backend/utils/cache/plancache.c modified +2 −4
src/backend/utils/cache/typcache.c modified +1 −1
src/backend/utils/error/elog.c modified +1 −1
src/backend/utils/hash/dynahash.c modified +6 −6
src/backend/utils/mmgr/mcxt.c modified +1 −1
src/backend/utils/sort/tuplesortvariants.c modified +6 −6
src/backend/utils/sort/tuplestore.c modified +5 −5
src/bin/pg_dump/pg_backup_archiver.c modified +2 −2
src/bin/pg_dump/pg_backup_custom.c modified +3 −3
src/bin/pg_dump/pg_backup_directory.c modified +3 −3
src/bin/pg_dump/pg_backup_tar.c modified +4 −4
src/bin/psql/mainloop.c modified +1 −1
src/bin/psql/startup.c modified +1 −1
src/include/common/pg_prng.h modified +1 −1
src/interfaces/ecpg/ecpglib/connect.c modified +1 −1
src/interfaces/ecpg/ecpglib/descriptor.c modified +2 −2
src/interfaces/ecpg/ecpglib/memory.c modified +1 −1
src/pl/plpgsql/src/pl_comp.c modified +2 −2
src/pl/plpgsql/src/pl_exec.c modified +5 −5
src/pl/plpgsql/src/pl_handler.c modified +1 −1
src/pl/plpython/plpy_exec.c modified +2 −2
src/test/isolation/isolationtester.c modified +1 −1
src/test/modules/test_regex/test_regex.c modified +1 −1

Discussion