Suppress complaints about leaks in TS dictionary loading.
Tom Lane <tgl@sss.pgh.pa.us>
Suppress complaints about leaks in TS dictionary loading. Like the situation with function cache loading, text search dictionary loading functions tend to leak some cruft into the dictionary's long-lived cache context. To judge by the examples in the core regression tests, not very many bytes are at stake. Moreover, I don't see a way to prevent such leaks without changing the API for TS template initialization functions: right now they do not have to worry about making sure that their results are long-lived. Hence, I think we should install a suppression rule rather than trying to fix this completely. However, I did grab some low-hanging fruit: several places were leaking the result of get_tsearch_config_filename. This seems worth doing mostly because they are inconsistent with other dictionaries that were freeing it already. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/285483.1746756246@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/tsearch/dict_ispell.c | modified | +12 −6 |
| src/backend/tsearch/dict_synonym.c | modified | +1 −0 |
| src/backend/tsearch/dict_thesaurus.c | modified | +4 −3 |
| src/backend/utils/cache/ts_cache.c | modified | +3 −1 |
| src/tools/valgrind.supp | modified | +12 −0 |
Discussion
- Why our Valgrind reports suck 32 messages · 2025-05-09 → 2026-06-12