Fix usage of whole-row variables in WCO and RLS policy expressions.
Tom Lane <tgl@sss.pgh.pa.us>
Fix usage of whole-row variables in WCO and RLS policy expressions. Since WITH CHECK OPTION was introduced, ExecInitModifyTable has initialized WCO expressions with the wrong plan node as parent -- that is, it passed its input subplan not the ModifyTable node itself. Up to now we thought this was harmless, but bug #16006 from Vinay Banakar shows it's not: if the input node is a SubqueryScan then ExecInitWholeRowVar can get confused into doing the wrong thing. (The fact that ExecInitWholeRowVar contains such logic is certainly a horrid kluge that doesn't deserve to live, but figuring out another way to do that is a task for some other day.) Andres had already noticed the wrong-parent mistake and fixed it in commit 148e632c0, but not being aware of any user-visible consequences, he quite reasonably didn't back-patch. This patch is simply a back-patch of 148e632c0, plus addition of a test case based on bug #16006. I also added the test case to v12/HEAD, even though the bug is already fixed there. Back-patch to all supported branches. 9.4 lacks RLS policies so the new test case doesn't work there, but I'm pretty sure a test could be devised based on using a whole-row Var in a plain WITH CHECK OPTION condition. (I lack the cycles to do so myself, though.) Andres Freund and Tom Lane Discussion: https://postgr.es/m/16006-99290d2e4642cbd5@postgresql.org Discussion: https://postgr.es/m/20181205225213.hiwa3kgoxeybqcqv@alap3.anarazel.de
Files
| Path | Change | +/− |
|---|---|---|
| src/test/regress/expected/rowsecurity.out | modified | +34 −0 |
| src/test/regress/sql/rowsecurity.sql | modified | +19 −0 |
Discussion
- Wrong parent node for WCO expressions in nodeModifyTable.c? 1 message · 2018-12-05
- BUG #16006: Update queries fail on a table having any policy with a function that takes a whole-row var as arg 8 messages · 2019-09-12 → 2019-09-13