Horton

Use consistent style for checking return from system calls

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 7e9a4c5c3dca0d9637812d8991e96fc8f46800d9
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2019-07-07T13:28:49Z
Releases: 13.0 
Use consistent style for checking return from system calls

Use

    if (something() != 0)
        error ...

instead of just

    if (something)
        error ...

The latter is not incorrect, but it's a bit confusing and not the
common style.

Discussion: https://www.postgresql.org/message-id/flat/5de61b6b-8be9-7771-0048-860328efe027%402ndquadrant.com

Files

PathChange+/−
contrib/pg_stat_statements/pg_stat_statements.c modified +1 −1
src/backend/access/heap/rewriteheap.c modified +2 −2
src/backend/access/transam/slru.c modified +6 −6
src/backend/access/transam/timeline.c modified +3 −3
src/backend/access/transam/twophase.c modified +1 −1
src/backend/access/transam/xlog.c modified +7 −7
src/backend/libpq/be-fsstubs.c modified +2 −2
src/backend/postmaster/postmaster.c modified +1 −1
src/backend/replication/logical/origin.c modified +2 −2
src/backend/replication/logical/reorderbuffer.c modified +1 −1
src/backend/replication/logical/snapbuild.c modified +2 −2
src/backend/replication/slot.c modified +2 −2
src/backend/replication/walsender.c modified +1 −1
src/backend/storage/file/copydir.c modified +2 −2
src/backend/storage/file/fd.c modified +5 −5
src/backend/storage/ipc/dsm_impl.c modified +1 −1
src/backend/utils/cache/relmapper.c modified +2 −2
src/common/controldata_utils.c modified +3 −3
src/interfaces/libpq/fe-lobj.c modified +1 −1

Discussion