Add missing assign hook for GUC checkpoint_completion_target
Michael Paquier <michael@paquier.xyz>
Add missing assign hook for GUC checkpoint_completion_target This is wrong since 88e9823, that has switched the WAL sizing configuration from checkpoint_segments to min_wal_size and max_wal_size. This missed the recalculation of the internal value of the internal "CheckPointSegments", that works as a mapping of the old GUC checkpoint_segments, on reload, for example, and it controls the timing of checkpoints depending on the volume of WAL generated. Most users tend to leave checkpoint_completion_target at 0.9 to smooth the I/O workload, which is why I guess this has gone unnoticed for so long, still it can be useful to tweak and reload the value dynamically in some cases to control the timing of checkpoints. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com Backpatch-through: 11
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/misc/guc_tables.c | modified | +1 −1 |
Discussion
- Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly 4 messages · 2022-12-26 → 2023-01-19