Horton

Don't include execnodes.h in replication/conflict.h

Álvaro Herrera <alvherre@kurilemu.de>

View on postgr.es
Commit: 7e638d7f5093fd24837ebe709135fa16ef8e3e7b
Author: Álvaro Herrera <alvherre@kurilemu.de>
Date: 2025-09-25T12:52:41Z
Releases: 19 (unreleased) 
Don't include execnodes.h in replication/conflict.h

... which silently propagates a lot of headers into many places
via pgstat.h, as evidenced by the variety of headers that this patch
needs to add to seemingly random places.  Add a minimum of typedefs to
conflict.h to be able to remove execnodes.h, and fix the fallout.

Backpatch to 18, where conflict.h first appeared.

Discussion: https://postgr.es/m/202509191927.uj2ijwmho7nv@alvherre.pgsql

Files

PathChange+/−
src/backend/access/transam/multixact.c modified +1 −0
src/backend/access/transam/xlogrecovery.c modified +1 −0
src/backend/storage/ipc/waiteventset.c modified +1 −0
src/backend/utils/activity/pgstat_backend.c modified +1 −0
src/include/pgstat.h modified +1 −0
src/include/replication/conflict.h modified +8 −1

Discussion