Horton

Code review for commit b6e1157e7d

Amit Langote <amitlan@postgresql.org>

View on postgr.es
Commit: 7c7412cae3ea8f8accdec1022969a9360b74f253
Author: Amit Langote <amitlan@postgresql.org>
Date: 2023-07-21T10:15:34Z
Releases: 17.0 
Code review for commit b6e1157e7d

b6e1157e7d made some changes to enforce that
JsonValueExpr.formatted_expr is always set and is the expression that
gives a JsonValueExpr its runtime value, but that's not really
apparent from the comments about and the code manipulating
formatted_expr.  This commit fixes that.

Per suggestion from Álvaro Herrera.

Discussion: https://postgr.es/m/20230718155313.3wqg6encgt32adqb%40alvherre.pgsql

Files

PathChange+/−
src/backend/nodes/makefuncs.c modified +4 −7
src/backend/nodes/nodeFuncs.c modified +1 −3
src/backend/parser/gram.y modified +3 −1
src/backend/parser/parse_expr.c modified +11 −6
src/include/nodes/makefuncs.h modified +2 −1
src/include/nodes/primnodes.h modified +3 −2

Discussion