Avoid O(N^2) behavior when enlarging SPI tuple table in spi_printtup().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 7c57449fc5855361d3a69374192c58fb68ce3e67
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2015-08-22T00:32:41Z
Releases: 9.0.23
Avoid O(N^2) behavior when enlarging SPI tuple table in spi_printtup().

For no obvious reason, spi_printtup() was coded to enlarge the tuple
pointer table by just 256 slots at a time, rather than doubling the size at
each reallocation, as is our usual habit.  For very large SPI results, this
makes for O(N^2) time spent in repalloc(), which of course soon comes to
dominate the runtime.  Use the standard doubling approach instead.

This is a longstanding performance bug, so back-patch to all active
branches.

Neil Conway

Files

PathChange+/−
src/backend/executor/spi.c modified +2 −1