Refactor nbtree high key truncation.

Peter Geoghegan <pg@bowt.ie>

Commit: 7c2dbc691c3e19b7d33c78f6c8aacc6e0cab510b
Author: Peter Geoghegan <pg@bowt.ie>
Date: 2020-03-30T22:52:39Z
Releases: 13.0
Refactor nbtree high key truncation.

Simplify _bt_truncate(), the routine that generates truncated leaf page
high keys.  Remove a micro-optimization that avoided a second palloc0()
call (this was used when a heap TID was needed in the final pivot tuple,
though only when the index happened to not be an INCLUDE index).

Removing this dubious micro-optimization allows _bt_truncate() to use
the index_truncate_tuple() indextuple.c utility routine in all cases.
This was already the common case.

This commit is a HEAD-only follow up to bugfix commit 4b42a899.

Files

PathChange+/−
src/backend/access/nbtree/nbtutils.c modified +45 −85