Horton

Remove incorrect assertion for INSERT in logical replication's publisher

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 7c21a964ef8a3b51f1fe0571054343ac0941008e
Author: Michael Paquier <michael@paquier.xyz>
Date: 2020-01-12T13:44:59Z
Releases: 12.2 
Remove incorrect assertion for INSERT in logical replication's publisher

On the publisher, it was assumed that an INSERT change cannot happen for
a relation with no replica identity.  However this is true only for a
change that needs references to old rows, aka UPDATE or DELETE, so
trying to use logical replication with a relation that has no replica
identity led to an assertion failure in the publisher when issuing an
INSERT.  This commit removes the incorrect assertion, and adds more
regression tests to provide coverage for relations without replica
identity.

Reported-by: Neha Sharma
Author: Dilip Kumar, Michael Paquier
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/CANiYTQsL1Hb8_Km08qd32svrqNumXLJeoGo014O7VZymgOhZEA@mail.gmail.com
Backpatch-through: 10

Files

PathChange+/−
src/backend/replication/logical/proto.c modified +0 −4
src/test/subscription/t/001_rep_changes.pl modified +14 −2

Discussion