Use perl warnings pragma consistently

Andrew Dunstan <andrew@dunslane.net>

Commit: 7be5d8df1f74b78620167d3abf32ee607e728919
Author: Andrew Dunstan <andrew@dunslane.net>
Date: 2020-04-13T15:55:45Z
Releases: 13.0
Use perl warnings pragma consistently

We've had a mixture of the warnings pragma, the -w switch on the shebang
line, and no warnings at all. This patch removes the -w swicth and add
the warnings pragma to all perl sources missing it. It raises the
severity of the TestingAndDebugging::RequireUseWarnings  perlcritic
policy to level 5, so that we catch any future violations.

Discussion: https://postgr.es/m/20200412074245.GB623763@rfd.leadboat.com

Files

PathChange+/−
contrib/intarray/bench/bench.pl modified +1 −0
contrib/intarray/bench/create_test.pl modified +2 −0
contrib/seg/seg-validate.pl modified +1 −0
contrib/seg/sort-segments.pl modified +1 −0
doc/src/sgml/mk_feature_tables.pl modified +2 −1
src/backend/catalog/genbki.pl modified +1 −1
src/backend/utils/Gen_fmgrtab.pl modified +1 −1
src/backend/utils/mb/Unicode/convutils.pm modified +1 −0
src/backend/utils/mb/Unicode/UCS_to_BIG5.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_EUC_CN.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_EUC_JIS_2004.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_EUC_KR.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_EUC_TW.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_GB18030.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_JOHAB.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_most.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_SHIFT_JIS_2004.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_SJIS.pl modified +2 −0
src/backend/utils/mb/Unicode/UCS_to_UHC.pl modified +2 −0
src/backend/utils/sort/gen_qsort_tuple.pl modified +2 −1
src/bin/psql/create_help.pl modified +2 −1
src/interfaces/libpq/test/regress.pl modified +2 −1
src/pl/plperl/plc_perlboot.pl modified +1 −0
src/pl/plperl/plperl_opmask.pl modified +1 −1
src/test/locale/sort-test.pl modified +1 −0
src/test/perl/SimpleTee.pm modified +1 −0
src/tools/fix-old-flex-code.pl modified +1 −1
src/tools/msvc/build.pl modified +1 −0
src/tools/msvc/pgbison.pl modified +2 −0
src/tools/msvc/pgflex.pl modified +2 −0
src/tools/msvc/vcregress.pl modified +1 −0
src/tools/perlcheck/perlcriticrc modified +4 −0
src/tools/pginclude/pgcheckdefines modified +2 −1
src/tools/version_stamp.pl modified +2 −1

Discussion