Fix handling of changed-Param signaling for CteScan plan nodes. We were using
Tom Lane <tgl@sss.pgh.pa.us>
Fix handling of changed-Param signaling for CteScan plan nodes. We were using the "cteParam" as a proxy for the possibility that the underlying CTE plan depends on outer-level variables or Params, but that doesn't work very well because it sometimes causes calling subqueries to be treated as SubPlans when they could be InitPlans. This is inefficient and also causes the outright failure exhibited in bug #4902. Instead, leave the cteParam out of it and copy the underlying CTE plan's extParams directly. Per bug #4902 from Marko Tiikkaja.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/optimizer/plan/subselect.c | modified | +30 −4 |
| src/test/regress/expected/with.out | modified | +41 −0 |
| src/test/regress/sql/with.sql | modified | +16 −0 |