pgstat: drop subscription stats without slot as well, fix comment

Andres Freund <andres@anarazel.de>

Commit: 7b64e4b3fa04769b725306a75bf3dd26e5a854fa
Author: Andres Freund <andres@anarazel.de>
Date: 2022-07-06T15:56:34Z
Releases: 16.0
pgstat: drop subscription stats without slot as well, fix comment

There's no reason anymore to only drop subscription stats if associated with a
slot, now that stats drops are transactional. And since there's now no other
cleanup of stats, this would lead to stats for slot-less subscriptions to get
leaked (however most slot-less subs won't have stats).

Additionally, the comment referring to autovacuum cleaning up stats was
clearly outdated.

Author: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CAD21AoAwiby3HeJE7vJe16Gr75RFfJ640dyHqvsiUhyKJTXPtw@mail.gmail.com
Backpatch: 15-

Files

PathChange+/−
src/backend/commands/subscriptioncmds.c modified +2 −8

Discussion