Cope with inplace update making catcache stale during TOAST fetch.
Noah Misch <noah@leadboat.com>
Cope with inplace update making catcache stale during TOAST fetch. This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of inplace updates. Trouble requires an inplace update of a catalog having a TOAST table, so only pg_database was at risk. (The other catalog on which core code performs inplace updates, pg_class, has no TOAST table.) Trouble would require something like the inplace-inval.spec test. Consider GRANT ... ON DATABASE fetching a stale row from cache and discarding a datfrozenxid update that vac_truncate_clog() has already relied upon. Back-patch to v12 (all supported versions). Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/catalog/catalog.c | modified | +21 −0 |
| src/backend/utils/cache/catcache.c | modified | +41 −3 |
| src/include/catalog/catalog.h | modified | +2 −0 |
Discussion
- Re: Recovering from detoast-related catcache invalidations 26 messages · 2024-01-11 → 2025-12-18
- race condition in pg_class 86 messages · 2023-10-25 → 2026-02-16