Horton

remove_rel_from_query() must clean up PlaceHolderVar.phrels fields.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 798c0176342150c8fe1404b0007b299db2e73ce0
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-02-08T19:08:46Z
Releases: 16.0 
remove_rel_from_query() must clean up PlaceHolderVar.phrels fields.

While we got away with this sloppiness before, it's not okay now
that fee7b77b9 caused build_joinrel_tlist() to make use of phrels.
Per report from Robins Tharakan.

Richard Guo (some cosmetic tweaks by me)

Discussion: https://postgr.es/m/CAMbWs4_ngw9sKxpTE8hqk=-ooVX_CQP3DarA4HzkRMz_JKpTrA@mail.gmail.com

Files

PathChange+/−
src/backend/optimizer/plan/analyzejoins.c modified +10 −7
src/test/regress/expected/join.out modified +16 −0
src/test/regress/sql/join.sql modified +7 −0

Discussion