Correctly update hasSubLinks while mutating a rule action.
Tom Lane <tgl@sss.pgh.pa.us>
Correctly update hasSubLinks while mutating a rule action. rewriteRuleAction neglected to check for SubLink nodes in the securityQuals of range table entries. This could lead to failing to convert such a SubLink to a SubPlan, resulting in assertion crashes or weird errors later in planning. In passing, fix some poor coding in rewriteTargetView: we should not pass the source parsetree's hasSubLinks field to ReplaceVarsFromTargetList's outer_hasSubLinks. ReplaceVarsFromTargetList knows enough to ignore that when a Query node is passed, but it's still confusing and bad precedent: if we did try to update that flag we'd be updating a stale copy of the parsetree. Per bug #17972 from Alexander Lakhin. This has been broken since we added RangeTblEntry.securityQuals (although the presented test case only fails back to 215b43cdc), so back-patch all the way. Discussion: https://postgr.es/m/17972-f422c094237847d0@postgresql.org
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/rewrite/rewriteHandler.c | modified | +3 −1 |
| src/test/regress/expected/updatable_views.out | modified | +32 −0 |
| src/test/regress/sql/updatable_views.sql | modified | +17 −0 |
Discussion
- BUG #17972: Assert failed in pull_varattnos_walker() for view with subquery and security qual 2 messages · 2023-06-13