Revert patch for taking fewer snapshots.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 786afc1ce53126feecf4d02e96e7455669ccbf5a
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-11-26T20:55:51Z
Releases: 9.2.2
Revert patch for taking fewer snapshots.

This reverts commit d573e239f03506920938bf0be56c868d9c3416da, "Take fewer
snapshots".  While that seemed like a good idea at the time, it caused
execution to use a snapshot that had been acquired before locking any of
the tables mentioned in the query.  This created user-visible anomalies
that were not present in any prior release of Postgres, as reported by
Tomas Vondra.  While this whole area could do with a redesign (since there
are related cases that have anomalies anyway), it doesn't seem likely that
any future patch would be reasonably back-patchable; and we don't want 9.2
to exhibit a behavior that's subtly unlike either past or future releases.
Hence, revert to prior code while we rethink the problem.

Files