Horton

Adjust tuplesort API to have bitwise option flags

David Rowley <drowley@postgresql.org>

View on postgr.es
Commit: 77bae396df3f6f883f58f1877b7c08eb3ebb6b63
Author: David Rowley <drowley@postgresql.org>
Date: 2022-04-04T10:24:59Z
Releases: 15.0 
Adjust tuplesort API to have bitwise option flags

This replaces the bool flag for randomAccess.  An upcoming patch requires
adding another option, so instead of breaking the API for that, then
breaking it again one day if we add more options, let's just break it
once.  Any boolean options we add in the future will just make use of an
unused bit in the flags.

Any extensions making use of tuplesorts will need to update their code
to pass TUPLESORT_RANDOMACCESS instead of true for randomAccess.
TUPLESORT_NONE can be used for a set of empty options.

Author: David Rowley
Reviewed-by: Justin Pryzby
Discussion: https://postgr.es/m/CAApHDvoH4ASzsAOyHcxkuY01Qf%2B%2B8JJ0paw%2B03dk%2BW25tQEcNQ%40mail.gmail.com

Files

PathChange+/−
src/backend/access/gist/gistbuild.c modified +1 −1
src/backend/access/hash/hashsort.c modified +1 −1
src/backend/access/heap/heapam_handler.c modified +1 −1
src/backend/access/nbtree/nbtsort.c modified +3 −3
src/backend/catalog/index.c modified +1 −1
src/backend/executor/nodeAgg.c modified +3 −3
src/backend/executor/nodeIncrementalSort.c modified +2 −2
src/backend/executor/nodeSort.c modified +6 −2
src/backend/utils/adt/orderedsetaggs.c modified +8 −2
src/backend/utils/sort/tuplesort.c modified +60 −51
src/include/utils/tuplesort.h modified +13 −6

Discussion