Make dblink try harder to form useful error messages

Joe Conway <mail@joeconway.com>

Commit: 76943f54a743e3d7875a6772fec89bb57a8f2118
Author: Joe Conway <mail@joeconway.com>
Date: 2016-12-22T17:47:36Z
Releases: 9.4.11
Make dblink try harder to form useful error messages

When libpq encounters a connection-level error, e.g. runs out of memory
while forming a result, there will be no error associated with PGresult,
but a message will be placed into PGconn's error buffer. postgres_fdw
takes care to use the PGconn error message when PGresult does not have
one, but dblink has been negligent in that regard. Modify dblink to mirror
what postgres_fdw has been doing.

Back-patch to all supported branches.

Author: Joe Conway
Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com

Files

PathChange+/−
contrib/dblink/dblink.c modified +22 −9

Discussion