Prefer pg_any_to_server/pg_server_to_any over pg_do_encoding_conversion.
Tom Lane <tgl@sss.pgh.pa.us>
Prefer pg_any_to_server/pg_server_to_any over pg_do_encoding_conversion. A large majority of the callers of pg_do_encoding_conversion were specifying the database encoding as either source or target of the conversion, meaning that we can use the less general functions pg_any_to_server/pg_server_to_any instead. The main advantage of using the latter functions is that they can make use of a cached conversion-function lookup in the common case that the other encoding is the current client_encoding. It's notationally cleaner too in most cases, not least because of the historical artifact that the latter functions use "char *" rather than "unsigned char *" in their APIs. Note that pg_any_to_server will apply an encoding verification step in some cases where pg_do_encoding_conversion would have just done nothing. This seems to me to be a good idea at most of these call sites, though it partially negates the performance benefit. Per discussion of bug #9210.
Files
| Path | Change | +/− |
|---|---|---|
| contrib/pg_stat_statements/pg_stat_statements.c | modified | +3 −5 |
| contrib/sslinfo/sslinfo.c | modified | +2 −8 |
| src/backend/commands/extension.c | modified | +2 −6 |
| src/backend/snowball/dict_snowball.c | modified | +2 −8 |
| src/backend/tsearch/ts_locale.c | modified | +1 −4 |
| src/backend/utils/adt/pg_locale.c | modified | +9 −14 |
| src/backend/utils/adt/xml.c | modified | +9 −18 |
| src/backend/utils/mb/mbutils.c | modified | +3 −1 |
| src/pl/plperl/plperl.c | modified | +2 −6 |
| src/pl/plperl/plperl_helpers.h | modified | +7 −18 |
| src/pl/plpython/plpy_util.c | modified | +5 −10 |
| src/pl/tcl/pltcl.c | modified | +6 −2 |