Use binary search instead of brute-force scan in findNamespace().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 73cc7d3b240e1d46b1996382e5735a820f8bc3f7
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-05-25T18:35:37Z
Releases: 9.2.0
Use binary search instead of brute-force scan in findNamespace().

The previous coding presented a significant bottleneck when dumping
databases containing many thousands of schemas, since the total time
spent searching would increase roughly as O(N^2) in the number of objects.
Noted by Jeff Janes, though I rewrote his proposed patch to use the
existing findObjectByOid infrastructure.

Since this is a longstanding performance bug, backpatch to all supported
versions.

Files

PathChange+/−
src/bin/pg_dump/common.c modified +16 −2
src/bin/pg_dump/pg_dump.c modified +14 −21
src/bin/pg_dump/pg_dump.h modified +1 −0