Horton

Improve implementation of CRE-stack-flattening in map_variable_attnos().

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 73937119bfd07a140da4817f5ca949351942ffdc
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-10-13T17:43:55Z
Releases: 11.0 
Improve implementation of CRE-stack-flattening in map_variable_attnos().

I (tgl) objected to the obscure implementation introduced in commit
1c497fa72.  This one seems a bit less action-at-a-distance-y, at the
price of repeating a few lines of code.

Improve the comments about what the function is doing, too.

Amit Khandekar, whacked around a bit more by me

Discussion: https://postgr.es/m/CAJ3gD9egYTyHUH0nTMxm8-1m3RvdqEbaTyGC-CUNtYf7tKNDaQ@mail.gmail.com

Files

PathChange+/−
src/backend/rewrite/rewriteManip.c modified +55 −46

Discussion